-
Type:
Build Failure
-
Resolution: Fixed
-
Priority:
Major - P3
-
Affects Version/s: None
-
Component/s: None
-
Labels:None
I observed the following error building the driver against PHP 7.4 and 8.0:
In file included from /home/jmikola/bin/php-bin/php-8.0/include/php/main/php.h:318,
from /home/jmikola/workspace/mongodb/phpc/php_phongo.c:24:
/home/jmikola/bin/php-bin/php-8.0/include/php/main/php_syslog.h:40:1: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
40 | PHPAPI void php_closelog();
| ^~~~~~
In file included from /home/jmikola/workspace/mongodb/phpc/php_phongo.c:24:
/home/jmikola/bin/php-bin/php-8.0/include/php/main/php.h:336:46: error: function declaration isn’t a prototype [-Werror=strict-prototypes]
336 | static inline ZEND_ATTRIBUTE_DEPRECATED void php_std_error_handling() {}
| ^~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make: *** [Makefile:737: php_phongo.lo] Error 1
Both of these appear to have been fixed upstream in PHP 8.1+:
- php_std_error_handling in php/php-src@c40231a for PHP 8.1.0
- php_closelog in php/php-src@d9cca44 for PHP 8.1.8
This harks back to PHPC-2166, where we made similar fixes in the driver (as well as libmongoc and libmongocrypt) to satisfy -Wstrict-prototypes. I'm not sure why we didn't catch the issue with PHP 8.0 and earlier then.
For reference, my local compiler is:
$ cc -v Using built-in specs. COLLECT_GCC=cc COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/11/lto-wrapper OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa OFFLOAD_TARGET_DEFAULT=1 Target: x86_64-linux-gnu Configured with: ../src/configure -v --with-pkgversion='Ubuntu 11.4.0-1ubuntu1~22.04' --with-bugurl=file:///usr/share/doc/gcc-11/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-11 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-bootstrap --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/gcc-11-XeT9lY/gcc-11-11.4.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/gcc-11-XeT9lY/gcc-11-11.4.0/debian/tmp-gcn/usr --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu --with-build-config=bootstrap-lto-lean --enable-link-serialization=2 Thread model: posix Supported LTO compression algorithms: zlib zstd gcc version 11.4.0 (Ubuntu 11.4.0-1ubuntu1~22.04)
Note that in igbinary/igbinary#170, the maintainer of that extension decided to remove -Wstrict-prototypes entirely (granted, it predated any of the upstream PHP patches).
We should look into enabling -Wstrict-prototypes only for PHP 8.1.8 and later. If that's not possible, then we can consider removing it entirely until our PHP requirement is bumped.
- is related to
-
PHPC-2166 Use void keyword in prototypes for functions that take no parameters
-
- Closed
-