Use Z_PARAM_STRING for required string params in Manager.c

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Minor - P4
    • 2.3.0
    • Affects Version/s: None
    • Component/s: None
    • PHP Drivers
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      Various execute methods in Manager.c use Z_PARAM_STRING_OR_NULL when parsing required string params (e.g. $db, $namespace). This was likely copied from the constructor's handling of the optional $uri param, but it would be more correct to use Z_PARAM_STRING for required params.

      The current macro usage back to e2f9144 from PHPC-2111.

            Assignee:
            Andreas Braun
            Reporter:
            Jeremy Mikola (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: