Uploaded image for project: 'PHP Driver: Extension'
  1. PHP Driver: Extension
  2. PHPC-2486

Use Z_PARAM_STRING for required string params in Manager.c

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • PHP Drivers
    • None
    • None
    • None
    • None
    • None
    • None

      Various execute methods in Manager.c use Z_PARAM_STRING_OR_NULL when parsing required string params (e.g. $db, $namespace). This was likely copied from the constructor's handling of the optional $uri param, but it would be more correct to use Z_PARAM_STRING for required params.

      The current macro usage back to e2f9144 from PHPC-2111.

            Assignee:
            Unassigned Unassigned
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              None
              None
              None
              None