Uploaded image for project: 'PHP Driver: Extension'
  1. PHP Driver: Extension
  2. PHPC-2511

Return success boolean from php_phongo_zval_to_bson

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: BSON
    • None
    • PHP Drivers
    • None
    • None
    • None
    • None
    • None
    • None

      Returning a success boolean from php_phongo_zval_to_bson would allow us to remove frequent checks of EG(exception) after it is called. This would be consistent with the design of phongo_zval_to_bson_value, which was introduced later.

      This was suggested by andreas.braun@mongodb.com in mongodb/mongo-php-driver#1763 (PHPC-2478).

            Assignee:
            Unassigned Unassigned
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              None
              None
              None
              None