Throw LogicException from Binary::getVectorType() and toArray()

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Unknown
    • 2.2.1
    • Affects Version/s: 2.2.0
    • Component/s: None
    • None
    • None
    • PHP Drivers
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      The initial implementation of Binary::getVectorType() and toArray() threw an InvalidArgumentException if either method was invoked on a Binary instance without the vector subtype. LogicException would be more appropriate, since this has nothing to do with the arguments (or lack thereof) passed to these methods. BadMethodCallException might also be appropriate, but PHPC doesn't extend that base class.

      This shouldn't constitute a BC break, as the docs will only ever refer to LogicException (see: php/doc-en#5370).

            Assignee:
            Jeremy Mikola (Inactive)
            Reporter:
            Jeremy Mikola (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: