Uploaded image for project: 'PHP Driver: Extension'
  1. PHP Driver: Extension
  2. PHPC-373

PHP 7: MAKE_STD_ZVAL is a gonner

    • Type: Icon: Improvement Improvement
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • 1.1.1
    • Affects Version/s: 1.0.0-alpha2
    • Component/s: None
    • Labels:
      None

      MAKE_STD_ZVAL() is gone in PHP 7.

      zval allocation macros ALLOC_ZVAL, ALLOC_INIT_ZVAL, MAKE_STD_ZVAL are removed. In most cases their usage indicate that zval* need to be changed into plain zval. Macro INIT_PZVAL is removed as well and its usages in most cases should be just removed.

      Furthermore, using zvals in php_phongo.c is problematic anyway:

      PHPNG doesn't require any involvement of pointers to pointers to zval. Most occurrences of zval** variables and parameters have to be changed into zval*. The corresponding Z_PP() macros that work with such variables should be changed into Z_P().

      Most of these instances should have already been converted to bson_t, as thats how it will eventually wind up as anyway.

            Assignee:
            bjori Hannes Magnusson
            Reporter:
            bjori Hannes Magnusson
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: