Uploaded image for project: 'PHP Driver: Extension'
  1. PHP Driver: Extension
  2. PHPC-422

Remove checks for null read preference tags

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Done
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: 1.0.0-beta1
    • Component/s: None
    • Labels:
      None

      When a mongoc_read_prefs_t is allocated, the tags are initialized to an empty BSON document. We should be able to remove checks like intern->read_preference->tags.len in the ReadPreference methods and debug handlers, as the places where we would return a NULL PHP value are never reached.

            Assignee:
            jmikola@mongodb.com Jeremy Mikola
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: