Consider using ZEND_HASH_FOREACH indirect macros for iteration

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Done
    • Priority: Minor - P4
    • 1.7.0
    • Affects Version/s: 1.2.0
    • Component/s: None
    • None
    • None
    • None
    • None
    • None
    • None

      phongo_bson_append() currently handles zval reference and indirect types. References are passed through ZVAL_DEREF() as-needed, and indirect types are routed through Z_INDIRECT_P(). The ZEND_HASH_FOREACH macros already have variants to automatically handled indirect types (e.g. ZEND_HASH_FOREACH_VAL_IND), so we should consider using those everywhere we iterate in PHP7.

            Assignee:
            Andreas Braun
            Reporter:
            Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: