Uploaded image for project: 'PHP Driver: Library'
  1. PHP Driver: Library
  2. PHPLIB-1054

Fix handling of CRYPT_SHARED_LIB_PATH and SKIP_CRYPT_SHARED env vars in test suite

XMLWordPrintableJSON

    • Type: Icon: Bug Bug
    • Resolution: Unresolved
    • Priority: Icon: Minor - P4 Minor - P4
    • None
    • Affects Version/s: 1.13.1
    • Component/s: Tests
    • Labels:

      PHPLIB-891 introduced the CRYPT_SHARED_LIB_PATH env var in 265810a. CRYPT_SHARED_LIB_PATH is only injected into the autoEncryption.extraOptions.cryptSharedLibPath driver option for clients created by ClientSideEncryptionSpecTest (i.e. CSFLE prose tests and legacy spec tests). It is therefore never used for unified CSFLE tests introduced in 5d48a1e for PHPLIB-820.

      On a related note, PHPLIB-911 introduced SKIP_CRYPT_SHARED in 0fe1a0f. Looking at run-tests.sh in that commit, it appears that SKIP_CRYPT_SHARED is never actually consulted when deciding to export CRYPT_SHARED_LIB_PATH.

      This issue appears to only affect library versions going back to 1.13.1, which is when SKIP_CRYPT_SHARED was introduced. Unified CSFLE spec tests did not appear in the test suite until 1.15.0.

            Assignee:
            Unassigned Unassigned
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: