Remove unused $server argument in Explainable::getCommandDocument

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Minor - P4
    • 1.16.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      The argument Server $server of Explainable::getCommandDocument is never used. I don't think this is ever necessary as the private methods createCommand never get the Server instance.

      The interface is internal, so we can change it without introducing a breaking change.

      This change will simplify unit-testing implementation of this methods PHPLIB-1144 as we don't have to instantiate or mock the final class Server.

              Assignee:
              Jérôme Tamarelle
              Reporter:
              Jérôme Tamarelle
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: