Uploaded image for project: 'PHP Driver: Library'
  1. PHP Driver: Library
  2. PHPLIB-1517

Remove interface MongoDB\Operation\Executable

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Unknown Unknown
    • 2.0.0
    • Affects Version/s: None
    • Component/s: None
    • None
    • PHP Drivers
    • Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      Any mention of this interface (e.g. in API docs) needs to be removed

      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      N/A

      3. Which versions of the driver/connector does this apply to?
      2.0+

      Show
      1. What would you like to communicate to the user about this feature? Any mention of this interface (e.g. in API docs) needs to be removed 2. Would you like the user to see examples of the syntax and/or executable code and its output? N/A 3. Which versions of the driver/connector does this apply to? 2.0+

      The interface MongoDB\Operation\Executable has a unique method execute(Server $server). It is never used for type hint and the return value is inconsistent between Operation classes. 

      https://github.com/mongodb/mongo-php-library/pull/1391#discussion_r1758290865

      This interface is internal, removing it is not a breaking change.

       

      The interface Explainable does not need to extend Executable as the method "execute" is never called in this context.

            Assignee:
            andreas.braun@mongodb.com Andreas Braun
            Reporter:
            jerome.tamarelle@mongodb.com Jérôme Tamarelle
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: