Uploaded image for project: 'PHP Driver: Library'
  1. PHP Driver: Library
  2. PHPLIB-459

Support better failure descriptions in DocumentsMatchConstraint

    XMLWordPrintableJSON

Details

    • Task
    • Status: Closed
    • Major - P3
    • Resolution: Fixed
    • None
    • 1.5.0
    • None
    • None

    Description

      DocumentsMatchConstraint currently makes it difficult to figure out where the comparison failure occurred when checking embedded documents. A few things can be done to improve things:

      • Using $this->exporter to stringify the expected document
      • Throwing a ComparisonFailure instead of a RuntimeException would allow for seeing a diff of the compared documents
      • Using additionalFailureDescription allows for adding more information as to what failed.

      Attachments

        Activity

          People

            andreas.braun@mongodb.com Andreas Braun
            andreas.braun@mongodb.com Andreas Braun
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: