Uploaded image for project: 'PHP Driver: Library'
  1. PHP Driver: Library
  2. PHPLIB-611

Intentionally failing tests for unified test runner are never executed

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 1.9.0-alpha1, 1.9.0
    • Affects Version/s: 1.8.0
    • Component/s: None
    • Labels:
      None

      In 4608a73, the UnifiedSpecTest::testFailingTests method calls a non-existent "testCase" method. This error was ignored because the surrounding try/catch uses Throwable instead of Exception.

      Changing the catch condition highlights the issue. When fixing this, we should confirm that all of the "valid-fail" test cases actually fail with exceptions and none create PHP errors.

            Assignee:
            jmikola@mongodb.com Jeremy Mikola
            Reporter:
            jmikola@mongodb.com Jeremy Mikola
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: