Uploaded image for project: 'Python Driver'
  1. Python Driver
  2. PYTHON-2331

set_memory_error warning: function declaration isn’t a prototype

    • Type: Icon: Bug Bug
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 3.11
    • Affects Version/s: None
    • Component/s: None
    • None

      I get the following warning when compiling the C extensions for manylinux + Python 3.5:

      gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -Ibson -I/opt/python/cp35-cp35m/include/python3.5m -c bson/buffer.c -o build/temp.linux-aarch64-3.5/bson/buffer.o
      bson/buffer.c:36:13: warning: function declaration isn’t a prototype [-Wstrict-prototypes]
         36 | static void set_memory_error() {
            |             ^~~~~~~~~~~~~~~~
      gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -Ibson -I/opt/python/cp35-cp35m/include/python3.5m -c bson/encoding_helpers.c -o build/temp.linux-aarch64-3.5/bson/encoding_helpers.o
      

      Evergreen also displays this warning on Python 3.5:

       [2020/07/22 19:43:24.108] creating build/temp.linux-x86_64-3.5/pymongo
       [2020/07/22 19:43:24.108] gcc -pthread -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -Ibson -I/opt/python/3.5/include/python3.5m -c pymongo/_cmessagemodule.c -o build/temp.linux-x86_64-3.5/pymongo/_cmessagemodule.o
       [2020/07/22 19:43:24.466] gcc -pthread -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -Ibson -I/opt/python/3.5/include/python3.5m -c bson/buffer.c -o build/temp.linux-x86_64-3.5/bson/buffer.o
       [2020/07/22 19:43:24.502] bson/buffer.c:36: warning: function declaration isn't a prototype
       [2020/07/22 19:43:24.502] bson/buffer.c:36: warning: function declaration isn't a prototype
       [2020/07/22 19:43:24.531] gcc -pthread -shared -Wl,--enable-new-dtags,-rpath,/opt/python/3.5/lib build/temp.linux-x86_64-3.5/pymongo/_cmessagemodule.o build/temp.linux-x86_64-3.5/bson/buffer.o -L/opt/python/3.5/lib -lpython3.5m -o /data/mci/67ab2993bacfbf0405a484f33b26a074/src/pymongo/_cmessage.cpython-35m-x86_64-linux-gnu.so
      

      https://evergreen.mongodb.com/task/mongo_python_driver_tests_python_version_rhel62_test_ssl__platform~rhel62_auth~auth_ssl~ssl_python_version~3.5_coverage~coverage_test_2.6_standalone_7a539f227a9524b27ef469826ef9ee5bd4533773_20_07_22_18_49_57

            Assignee:
            shane.harvey@mongodb.com Shane Harvey
            Reporter:
            shane.harvey@mongodb.com Shane Harvey
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: