Remove duplicate test_detect_external_db

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Unknown
    • 4.7
    • Affects Version/s: None
    • Component/s: None
    • None
    • None
    • Python Drivers
    • Not Needed
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      test_detect_external_db is a duplicate test that we can remove. It's causing Motor's synchro test suite to fail:
      https://github.com/mongodb/mongo-python-driver/pull/1537/files#diff-527ca60d328d52ef4a82154a3572772f8a5367554e05d280f1535c43cfd9cdf8R600

      [2024/03/15 15:08:44.932] __________________ ERROR collecting test/test_custom_types.py __________________
[2024/03/15 15:08:44.932] ImportError while importing test module '/data/mci/7ce850cc4c58ec3950c2d23a8a39fc6e/src/.tox/synchro/tmp/mongo-python-driver/test/test_custom_types.py'.
[2024/03/15 15:08:44.932] Hint: make sure your test modules/packages have valid Python names.
[2024/03/15 15:08:44.932] Traceback:
[2024/03/15 15:08:44.932] /opt/python/3.7/lib/python3.7/importlib/__init__.py:127: in import_module
[2024/03/15 15:08:44.932]     return _bootstrap._gcd_import(name[level:], package, level)
[2024/03/15 15:08:44.932] test/test_custom_types.py:29: in <module>
[2024/03/15 15:08:44.932]     from test.test_client import IntegrationTest
[2024/03/15 15:08:44.932] test/test_client.py:105: in <module>
[2024/03/15 15:08:44.932]     from pymongo.mongo_client import MongoClient, _detect_external_db
[2024/03/15 15:08:44.932] E   ImportError: cannot import name '_detect_external_db' from 'synchro' (/data/mci/7ce850cc4c58ec3950c2d23a8a39fc6e/src/synchro/__init__.py)

      https://spruce.mongodb.com/task/motor_main__ssl~nossl_tox_env~synchro_py37_os~rhel84_test_latest_standalone_patch_9d00dd236e7a194f4359b8db0c29cbed361ce532_65f4c236fe10dd00071c4450_24_03_15_21_48_43/logs?execution=0&sortBy=STATUS&sortDir=ASC

            Assignee:
            Noah Stapp
            Reporter:
            Shane Harvey
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: