Uploaded image for project: 'Python Driver'
  1. Python Driver
  2. PYTHON-5302

Run ruff before synchro in pre-commit hooks

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Done
    • Priority: Icon: Unknown Unknown
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Python Drivers
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      Context

      If there are static linting failures, our synchro hook will fail and result in every synchronous file having git diffs until the issue is fixed. The synchro failure will also have no helpful information, causing a very frustrating situation.

      Definition of done

      Ruff should be run before synchro, to verify that there are no static linting failures.

      Pitfalls

      Note: we already run Ruff as part of the synchro script.

            Assignee:
            noah.stapp@mongodb.com Noah Stapp
            Reporter:
            noah.stapp@mongodb.com Noah Stapp
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: