SyncManager::run_file_action ignores delete result

This issue belongs to an archived project. You can view it, but you can't modify it. Learn more

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Minor - P4
    • None
    • Affects Version/s: None
    • Component/s: Sync

      When we call SyncManager::imediately_run_file_actions during manual client reset recovery while someone is holding a lock for the file (e.g. open the Realm with Studio on Windows), Core will report the action as successful even if it fails. The reason is that when the action is DeleteRealm, the result from remove_realm is ignored and we always return true:

      https://github.com/realm/realm-core/blob/165bb205de58ce87a900fff4e42de4c7d64b61cc/src/realm/object-store/sync/sync_manager.cpp#L179-L182

            Assignee:
            Jonathan Reams
            Reporter:
            Nikola Irinchev
            Archiver:
            Marc Greenfield

              Created:
              Updated:
              Resolved:
              Archived: