Uploaded image for project: 'Ruby Driver'
  1. Ruby Driver
  2. RUBY-2117

Rename Binary#to_string to Binary#to_s

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.12.0.rc0
    • Component/s: Encryption
    • Labels:
      None

      Description

      https://github.com/mongodb/mongo-ruby-driver/blob/master/lib/mongo/crypt/binary.rb#L126

      The Ruby convention for converting an object to string is to use the #to_s method. We follow it in, for example, BSON::ByteBuffer.

      Along this convention I propose renaming Mongo::Crypt::Binary#to_string to #to_s.

        Attachments

          Activity

            People

            Assignee:
            emily.giurleo Emily Giurleo
            Reporter:
            oleg.pudeyev Oleg Pudeyev
            Participants:
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: