Restore conditional skip logic in transactions spec runner

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Done
    • Priority: Unknown
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • None
    • Ruby Drivers
    • Hide

      1. What would you like to communicate to the user about this feature?
      2. Would you like the user to see examples of the syntax and/or executable code and its output?
      3. Which versions of the driver/connector does this apply to?

      Show
      1. What would you like to communicate to the user about this feature? 2. Would you like the user to see examples of the syntax and/or executable code and its output? 3. Which versions of the driver/connector does this apply to?
    • None
    • None
    • None
    • None
    • None
    • None

      A rubocop autocorrect in commit 8db64312b ("Enable rubocop on all files, with exceptions" — PR #3005) flattened the original if test.skip_reason and unless req.satisfied? guards in spec/runners/transactions.rb into bare skip calls inside a single before(:all) block.

      The result is two unconditional skip statements:

      before(:all) do
        ...
        skip test.skip_reason            # always skips, even when skip_reason is nil
        skip 'Requirements not satisfied' # always skips
        test.setup_test                   # never reached
      end
      

      Effect: every transactions_spec.rb and transactions_api_spec.rb example reports as PENDING: Requirements not satisfied (or PENDING: No reason given) regardless of cluster topology or actual requirements. The transactions spec test suite has not run locally on master since that commit (2026-03-27).

      Fix: restore the conditional checks (skip test.skip_reason if test.skip_reason and skip 'Requirements not satisfied' unless req.satisfied?) and pass the req block argument through.

            Assignee:
            Dmitry Rybakov
            Reporter:
            Dmitry Rybakov
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: