Uploaded image for project: 'Ruby Driver'
  1. Ruby Driver
  2. RUBY-440

Connection exception corrections and clarifications.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major - P3
    • Resolution: Fixed
    • Affects Version/s: 1.6.2
    • Fix Version/s: 1.7.0
    • Component/s: None
    • Labels:
      None

      Description

      https://github.com/mongodb/mongo-ruby-driver/blob/master/lib/mongo/util/tcp_socket.rb#L63-83

      There are a couple issues with this code:

      1. Any time an ERRNO-based exception is raised, we should report that to the user, at least in the exception message.

      2. The OperationFailure exception should be used only when MongoDB itself rejects the operation. For connection-level failures, we should raise ConnectionFailure.

      3. What's the difference between ConnectionFailure and ConnectionError? Probably should stick to just one of these.

        Attachments

          Activity

            People

            Assignee:
            tyler@10gen.com Tyler Brock
            Reporter:
            kbanker Kyle Banker
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: