Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-100313

Move PlanCacheCallbacksImpl to query exec

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Minor - P4 Minor - P4
    • 8.1.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Optimization
    • Fully Compatible
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      For SERVER-87128 we need to notify waiting threads that a plan cache key has been added to the plan cache. The best way to do it is to leverage PlanCacheCallbacks.

      Unfortunately, PlanCacheCallbacksImpl is implemented in query_plan_cache library while it is used in query_exec. To notify all waiting threads I need to add a dependency defined in query_exec. It seems that the best place for the PlanCacheCallbacksImpl is query_exec, where it is used, and its interface PlanCacheCallbacks should remain in query_plan_cache.

      This purely refactoring change would allow to streamline implementation of SERVER-87128 and simplify its code review.

            Assignee:
            alexander.ignatyev@mongodb.com Alexander Ignatyev
            Reporter:
            alexander.ignatyev@mongodb.com Alexander Ignatyev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: