Provide different QuerySettingsService implementations for router and shard

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.2.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution
    • Fully Compatible
    • QE 2025-04-28
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      Currently the PQS module provides two different methods for the lookup on the router and shard. In order to make things simpler one could introduce a generic QuerySettingsService interface and provide two different implementations depending on the instance (via pimpl).

      The proposal would be to:

      • Provide such implementation, but do not adjust the callers with the new API, but instead delegate the implementation to the methods provided by the service instance (would require only query-settings team code review)
      • Adjust the callers with the new interface (the implementation is same, just interface change, therefore trivial review)

              Assignee:
              Denis Grebennicov
              Reporter:
              Denis Grebennicov
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: