Create MultiLet ABT node

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.2.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution
    • Fully Compatible
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      • derive from ABTOpDynamicArity<0>
      • the constructor accepts a vector of pairs of ProjectionName+ABT node, plus a final ABT node, that are stored in the flat vector inherited from ABTOpDynamicArity, plus a dedicated std::vector<ProjectionName>
      • add the new type to the known walkers, using the logic used for the Let node as a template:
        • SBEExpressionLowering
        • ExplainPrinter
        • LastRefsTransporter
        • ExpressionConstEval
        • TypeChecker
        • Vectorizer
        • ValueLifetime
      • add unit tests for the walkers to test the new logic
      • change makeLet(sbe::FrameId frameId, optimizer::ABTVector bindExprs, optimizer::ABT expr) so that it creates the MultiLet node if the feature flag is set to true
      • revisit the code in gen_expression.cpp that could be rewritten to use the makeLet helper that accepts the vector of bind expressions, e.g. the one in visitFast(const ExpressionAdd) and in generateSetExpression

              Assignee:
              Projjal Chanda
              Reporter:
              Alberto Massari
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: