Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-101676

De-template determineBatchesToCommit

    • Type: Icon: Task Task
    • Resolution: Fixed
    • Priority: Icon: Major - P3 Major - P3
    • 8.2.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Storage Execution
    • Fully Compatible
    • Storage Execution 2025-03-31, Storage Execution 2025-04-14
    • None
    • 0
    • None
    • None
    • None
    • None
    • None
    • None

      Also cleanup any related code, like the use of extractFromSelf.

      After the change to make each batch contains all of its own measurements, moving away from the old approach of having different measurements writing to the same bucket sharing a shared_pointer to the write batch, the de-duplication work inside of determineBatchesToCommit is no longer necessary. We still need to sort the batches by bucket order to prevent deadlocks (two clients trying to commit writes to buckets in different orders atomically).

      Besides de-templating the function, we can also repurpose it to only perform the sorting functionality.

            Assignee:
            damian.wasilewicz@mongodb.com Damian Wasilewicz
            Reporter:
            matt.kneiser@mongodb.com Matt Kneiser
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: