-
Type:
Task
-
Resolution: Unresolved
-
Priority:
Major - P3
-
None
-
Affects Version/s: None
-
Component/s: None
-
None
-
Networking & Observability
-
None
-
None
-
None
-
None
-
None
-
None
-
None
As we look into upgrading ASIO, I'd like us to evaluate whether it makes sense to set the ASIO_NO_DEPRECATE macro. When set, this macro fully disables deprecated behaviors. On principle, this seems like a good move, to ensure we're using the library as its authors intend for us to.
A concrete motivator that I have in making this request is to more nimbly avoid a clang-tidy warning that's cropped up with the v5 toolchain. One of the deprecated behaviors is a collection of method calls taking an error code outparameter rather than returning one. In many cases, our code calls such a method passing in an error code outparameter, so the work of using the intended pathway is already there. However, because we do not set the ASIO_NO_DEPRECATE macro, the method will still return an error code, and on v5, clang-tidy will complain if the returned error code isn't used. I highly suspect that if we enabled the macro, these methods would instead return void and clang-tidy would no longer complain.
- is related to
-
SERVER-98502 Fix incompatibilities with clang-tidy on LLVM 19
-
- Closed
-
- related to
-
SERVER-98502 Fix incompatibilities with clang-tidy on LLVM 19
-
- Closed
-