Restrict the usage of VersionContext::getOperationFCV()

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.2.0-rc0
    • Affects Version/s: 8.2.0-rc0
    • Component/s: None
    • None
    • Catalog and Routing
    • Fully Compatible
    • CAR Team 2025-04-14
    • None
    • 3
    • None
    • None
    • None
    • None
    • None
    • None

      The VersionContext::getOperationFCV() method returns the FCV associated an operation as a FCVSnapshot. This method is intended to be used in the FCV-gated feature flag implementation to implement operation FCV checking, but it may cause confusion with the second argument to FCVGatedFeatureFlag::isEnabled(VersionContext&, FCVSnapshot), which is not operation FCV but rather the global FCV.

      This ticket is for making VersionContext::getOperationFCV() callable only from within FCVGatedFeatureFlag and ShardingDDLCoordinator along with a short note in version_context.h for why this method should not be called from other code.

            Assignee:
            Robert Sander
            Reporter:
            Joan Bruguera Micó
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: