Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-102107

Reenable mongo polyfill check

    • Type: Icon: Bug Bug
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Server Programmability
    • ALL
    • Programmability 2025-03-31, Programmability 2025-04-14
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      In SERVER-96684, we turned off the MongoPolyfillCheck custom clang-tidy check. I was unable to identify a straightforward way to get it to pass its unit test while also not producing false positives. What we want is for the check to identify spelled-out uses of certain std:: names. What it has been written to do is to identify uses of std:: names, even through typedefs. Since we want to retain the ability to typedef a polyfill, the check is not written currently to do what we want. Oddly, the check behaved as we intended on the LLVM 12 API, and only started to exhibit the undesired, but documented, behavior on the v5 toolchain, which upgrades us to LLVM 19.

       

      Fix the check so that it doesn't look through typedefs, then re-enable it and schedule work to fix any violations that have cropped up.

            Assignee:
            alex.li@mongodb.com Alex Li
            Reporter:
            james.bronsted@mongodb.com James Bronsted
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              None
              None
              None
              None