Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-102282

Fix or document v5 transitional warning suppressions in SP-owned code

XMLWordPrintableJSON

    • Type: Icon: Task Task
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Server Programmability
    • SP Prioritized List
    • None
    • 0
    • None
    • None
    • None
    • None
    • None
    • None

      In SPM-3825, we suppressed a number of warnings emitted by the new compilers, some of which we did not immediately identify as being required or advisable long-term. Review all instances of MONGO_COMPILER_DIAGNOSTIC_IGNORED_TRANSITIONAL in the files owned by Server Programmability listed below.

      For each instance, either

      1. fix the code that causes the warning to be emitted and remove the suppression macros, or
      2. create a new macro similar to MONGO_COMPILER_DIAGNOSTIC_WORKAROUND_BOOST_SMALL_VECTOR and rewrite the TRANSITIONAL macro to use the WORKAROUND macro. Document why the suppression needs to remain in the codebase long-term.

      File list:

      src/mongo/db/client_strand.h
src/mongo/platform/compiler.h
src/mongo/util/future_impl.h
src/mongo/util/future_test_future_int.cpp
src/mongo/util/intrusive_counter.h

            Assignee:
            mathias@mongodb.com Mathias Stearn
            Reporter:
            james.bronsted@mongodb.com James Bronsted
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: