Loading...

XML

Word

Printable

JSON

Type: Task
Resolution: Unresolved
Priority: Major - P3
Fix Version/s: None
Affects Version/s: None
Component/s: None
Labels:
- M1

Assigned Teams:

Query Execution
Sprint:
QE 2025-04-28, QE 2025-05-12
Confidence Status:
None
Work Order:
3

Aha! Reference:
None
Tracking Level:
None
Risk Status:
None
Exec Notes:
None
Goal Name:
None
Goal Link:
None

With ~~SERVER-103766~~, the QE-relevant methods and fields from DocumentSource are moved to agg::Stage and DocumentSource inherits from agg::Stage making it a light refactoring.

In this ticket, we need to 'move' this inheritance 'down' the hierarchy:

DocumentSource inherits directly from RefCountable as before.
agg::Stage does not inherit from RefCountable anymore.
DocumentSource direct subclasses (around 80) inherit from both DocumentSource and agg::Stage (multiple inheritance).
Dome test-only and QO-only document sources inherit only from DocumentSource and do not need agg::Stage (please ask me if you need a list).
agg::Pipeline still contains StageContainer _stages, with StageContainer defined as std::list<boost::intrusive_ptr<Stage>>
we need to temporarily add void intrusive_ptr_add_ref(Stage*) and void intrusive_ptr_release(Stage*), because agg::Stage does not inherit from RefCountable anymore.

Prototype commit for the reference (might not fully match the current design): https://github.com/10gen/mongo/pull/34036/commits/0839eed81d7a4596b5d8e112a5e1f0ba65263016

We need to run the performance tests on this change.

depends on

SERVER-103766 Move DocumentSource's QE members to a parent class

Closed

is depended on by

SERVER-104225 Split DocumentSourceCursor into QO and QE components

Needs Scheduling

SERVER-104227 Split DocumentSourceMatch into QO and QE components

Needs Scheduling

SERVER-104228 Split DocumentSourceSingleDocumentTransforformation into QO and QE components

Needs Scheduling

SERVER-104229 Split DocumentSourceGroup and DocumentSourceStreamingGroup into QO and QE components

Needs Scheduling

SERVER-104230 Split DocumentSourceSort into QO and QE components

Needs Scheduling

SERVER-104231 Split DocumentSourceLookUp into QO and QE components

Needs Scheduling

SERVER-104232 Split DocumentSourceUnwind into QO and QE components

Needs Scheduling

SERVER-104234 Split DocumentSourceInternalSetWindowFields into QO and QE components

Needs Scheduling

SERVER-104238 Split DocumentSourceInternalDensify into QO and QE components

Needs Scheduling

SERVER-104240 Split DocumentSourceUnionWith into QO and QE components

Needs Scheduling

SERVER-104242 Split DocumentSourceGraphLookUp stage into QO and QE components

Needs Scheduling

is related to

SERVER-103766 Move DocumentSource's QE members to a parent class

Closed

(7 is depended on by, 1 is related to)

Assignee:: Daniel Tabacaru

Reporter:: Romans Kasperovics

Participants:: Daniel Tabacaru, Romans Kasperovics

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Created:: Apr 23 2025 02:26:47 PM UTC

Updated:: Apr 28 2025 06:07:28 PM UTC

Confidence Status Last Update:: 24/Apr/25 3:54 PM

Details

Description

Attachments

Issue Links

Activity

People

Dates