Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-104424

Query Execution code-owns unicode-related files in third-party libraries that they do not own

    • Type: Icon: Bug Bug
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution
    • ALL
    • None
    • 3
    • TBD
    • None
    • None
    • None
    • None
    • None
    • None

      I'm finding a number of files under third-party libraries owned by teams other than QE that are marked as code-owned by QE. One example is boost:

      src/third_party/boost/boost/regex/pending/unicode_iterator.hpp          @10gen/query-execution @svc-auto-approve-bot
      src/third_party/boost/boost/regex/v4/unicode_iterator.hpp               @10gen/query-execution @svc-auto-approve-bot
      src/third_party/boost/boost/regex/v5/unicode_iterator.hpp               @10gen/query-execution @svc-auto-approve-bot
      src/third_party/boost/boost/spirit/home/support/char_encoding/unicode/category_table.hpp  @10gen/query-execution @svc-auto-approve-bot
      src/third_party/boost/boost/spirit/home/support/char_encoding/unicode/lowercase_table.hpp  @10gen/query-execution @svc-auto-approve-bot
      src/third_party/boost/boost/spirit/home/support/char_encoding/unicode/query.hpp  @10gen/query-execution @svc-auto-approve-bot
      src/third_party/boost/boost/spirit/home/support/char_encoding/unicode/script_table.hpp  @10gen/query-execution @svc-auto-approve-bot
      src/third_party/boost/boost/spirit/home/support/char_encoding/unicode/uppercase_table.hpp  @10gen/query-execution @svc-auto-approve-bot
      src/third_party/boost/boost/spirit/home/support/char_encoding/unicode.hpp  @10gen/query-execution @svc-auto-approve-bot

      I believe this is because of a line in src/third_party/OWNERS.yml that intends to give QE ownership of all third-party libraries that take the name unicode*. The actual effect of that line is to assign all files and directories at any depth beneath src/third_party that take the name unicode*. I think if we change that line to read `"unicode-8.0.0"`, it will have the desired effect of assigning exactly that directory to QE.

            Assignee:
            projjal.chanda@mongodb.com Projjal Chanda
            Reporter:
            james.bronsted@mongodb.com James Bronsted
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: