Uploaded image for project: 'Core Server'
  1. Core Server
  2. SERVER-104962

insertDocsToOplogAndChangeCollections should not call OpObserver onInserts functions just to not break tests

    • Type: Icon: Improvement Improvement
    • Resolution: Unresolved
    • Priority: Icon: Major - P3 Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Replication
    • None
    • 3
    • TBD
    • None
    • None
    • None
    • None
    • None
    • None

      Secondaries used to insert into oplog using collection_internal::insertDocuments, but SERVER-103421 unified the code paths so that secondaries also call insertDocumentsForOplog the same way as primaries. However, collection_internal::insertDocuments also calls OpObserver's onInserts function, which shouldn't be necessary but they are currently relied upon by unit tests in oplog_application_test, where they register an OpObserver to receive inserted oplog documents and compare with the expected results.

            Assignee:
            Unassigned Unassigned
            Reporter:
            wei.hu@mongodb.com Wei Hu
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: