Inline BlockBasedDecompressAdaptor::push_back and avoid repeated calls to vector push_back

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Duplicate
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution
    • 200
    • None
    • 3
    • TBD
    • None
    • None
    • None
    • None
    • None
    • None
    • 0

      After the V5 toolchain upgrade, we saw some TSBS regressions (BF-37497) that appeared to be from block processing functions that used to be inlined by the compiler, but are no longer inlined.

      Adding inline to this function and also accessing the _tags and _vals memory directly instead of calling push_back seemed to bring the performance back to pre-V5 upgrade levels.

            Assignee:
            Matt Boros
            Reporter:
            Matt Boros
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: