Background

There is a test fixture db/exec/query_shard_server_test_fixture.cpp which uses CollectionShardingRuntime outside the db/s directory. To satisfy the Clang-Tidy mongo-collection-sharding-runtime-check check, NOLINTs were added.

I recently worked on SERVER-101914 to refactor the code to get rid of the NOLINTs. I realized the mongo-collection-sharding-runtime-check already had an exclusion to not check the file db/exec/query_shard_server_test_fixture.cpp, but that check was flawed. I fixed it in https://github.com/10gen/mongo/pull/36161 and removed the NOLINT.

Task

What remains is the use of CollectionShardingRuntime in the test fixture. The goal of this issue is to re-evaluate if the exclusion of db/exec/query_shard_server_test_fixture.cpp in mongo-collection-sharding-runtime-check should exist.