Missing return statement might cause failure in fsm test

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.2.0-rc0
    • Affects Version/s: None
    • Component/s: Sharding
    • None
    • Catalog and Routing
    • Fully Compatible
    • ALL
    • CAR Team 2025-06-23
    • 1
    • 🟢 On Track
    • 3
    • TBD
    • 🟥 DDL
    • None
    • None
    • None
    • None
    • None
    • None
    • 0

      SERVER-102818 added an extra suite to add and remove shards while running a fsm workload. As part of this, the movePrimary state had to be changed to check and retry a number of times if the destination shard was removed. However, when giving up, there is no return true; statement which would effectively stop the assert.soon execution.

      The purpose of this ticket is to fix this behavior, by either adding the statement, or, re-evaluating the usage of assert.soon, considering that as this is an fsm, eventually the movePrimary state would be re-executed, and simply adding the ShardNotFound error as a permitted failure for movePrimary. If we want to be more strict, we could add the error only if we are running in an add/remove shard suite.

            Assignee:
            Marcos José Grillo Ramirez
            Reporter:
            Marcos José Grillo Ramirez
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: