isRetryableError in utils.js is unreliable

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: Shell
    • None
    • DevProd Correctness
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      As part of the logic to decide if an error is retryable, isRetryableError() looks into the human-readable message of the error to look for a bunch of substrings. These substrings include common phrases such as "network error". This can easily lead to false positives, like one I encountered where it considered this error as retryable, leading to time wasted debugging an error that should've been trivial. This should be replaced with a more correct alternative that, ideally, doesn't look into a human readable message.

            Assignee:
            Unassigned
            Reporter:
            Aitor Esteve Alvarado
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: