Audit resmoke suites for unexpected state persisting after tests complete

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Query Execution
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      In SERVER-109544 it was discovered that setParameters can be persisted after a test ends, since the fixture doesn't reset after each run. This caused tests like histogram_ce_stability_pbt.js to make other tests fail by leaking the "planRankerMode: histogramCE" setting into a test which expects the default.

      We should check other suites to see if they can carry over state. setParameters leaking is a significant risk, we could be getting different coverage than expected.

      This ticket should also come up with a longterm solution for preventing unexpected state persisting between tests. Some options are

      • Failing the test if it doesn't clean up setParameters and other state when it's complete.
      • Setting CleanEveryN=1 in the passthrough fixture
      • Banning setParameter in certain suites

            Assignee:
            Unassigned
            Reporter:
            Matt Boros
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated: