Assert and replace invariants, fasserts, MONGO_UNREACHABLE and MONGO_UNIMPLEMENTED macros usage with tassert for logical pre-, post- conditions and for validating function arguments or user input{why it is safe and why it is valuable}.
This ticket is only concerned with the query owned code located in src/mongo/db/exec/sbe.
Assess the invariants against this checklist:
- Invariant is not on the write path.
- Invariant is not asserting data coming from the storage layer.
- Invariant is not asserting the shared state that's accessible from other threads.
- Tassert would release all the resources that are violating the invariant.
- Invariant is covered by either unit test of jstest.
1.
|
Audit invariants in sbe/values codebase | SERVER-110896 |
|
In Code Review | Serhii Lysenko |