-
Type:
Improvement
-
Resolution: Unresolved
-
Priority:
Major - P3
-
None
-
Affects Version/s: None
-
Component/s: None
-
None
-
Query Execution
-
None
-
None
-
None
-
None
-
None
-
None
-
None
The WithLock convention is used in the codebase to ensure that functions interacting with a class's internal mutex are called while holding the appropriate lock. This improves code clarity, enforces the proper locking contract, and reduces the risk of misuse.
- Identify methods in the QuerySettingsManager class that interact with its internal mutex.
- Refactor these methods to adopt the WithLock parameter convention.
- Update calling code to ensure it provides the necessary lock-holding resource when calling these methods.
Benefits:
- Improves code clarity and safety.
- Aligns CurOp with established best practices for mutex usage.
References:
See cpp_style.md for more information.