-
Type:
Improvement
-
Resolution: Fixed
-
Priority:
Minor - P4
-
Affects Version/s: None
-
Component/s: Query Execution
-
None
-
Query Execution
-
Fully Compatible
-
QE 2025-09-29
-
None
-
None
-
None
-
None
-
None
-
None
-
None
class DocumentSource currently still virtually inherits from RefCountable here:
// TODO SPM-4106: Remove virtual keyword once the refactoring is done. class DocumentSource : public virtual RefCountable {
The virtual inhertiance was necessary during the SPM-4106 transition period, when the individual DocumentSource subclasses inherited from both DocumentSource and exec::agg::Stage.
Now that no DocumentSource subclass inherits from exec::agg::Stage anymore, we should remove the virtual inheritance and the TODO from the code.
- is related to
-
SERVER-105494 Replace intrusive_ptr with unique_ptr in exec::agg::Pipeline::StageContainer
-
- Open
-