Do not virtually inherit from RefCountable in DocumentSource

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Fixed
    • Priority: Minor - P4
    • 8.3.0-rc0
    • Affects Version/s: None
    • Component/s: Query Execution
    • None
    • Query Execution
    • Fully Compatible
    • QE 2025-09-29
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      class DocumentSource currently still virtually inherits from RefCountable here:

      // TODO SPM-4106: Remove virtual keyword once the refactoring is done.
      class DocumentSource : public virtual RefCountable {
      

      The virtual inhertiance was necessary during the SPM-4106 transition period, when the individual DocumentSource subclasses inherited from both DocumentSource and exec::agg::Stage.
      Now that no DocumentSource subclass inherits from exec::agg::Stage anymore, we should remove the virtual inheritance and the TODO from the code.

            Assignee:
            Jan Steemann
            Reporter:
            Jan Steemann
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: