Assert ptr is valid in get() in handle.h

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Query Integration
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      It appears that the general pattern in the extensions code is to always call assertValid() before get() to verify that the underlying ptr in handle.h is valid before returning it. Is there a reason we don't call assertValid() or at least assert that the ptr != nullptr in get() to always verify before returning it? In certain places we don't follow the apparent aforementioned pattern. Could that lead to potential seg faults like here and here?

       

            Assignee:
            Unassigned
            Reporter:
            Adithi Raghavan
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: