Consider adding a warning log if setting a server parameter ends up a noop

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Workload Resilience
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      In multiple places we use a on_update callback set properly set server parameter, and we rely on Client::getcurrent() to do so. In many of those places, we simply perform a noop in the case the current thread does not have a client.

      In the case we don't have a client, we should consider adding a warning log so that calling those function on threads without client don't go completely silent. This should help diagnosing and debugging when setting a server parameter don't behave as expected.

      The places we can observe this includes, but it not limited to:

      • ShardSharedStateCache
      • IngressRequestRateLimiter
      • IngressAdmissionController

            Assignee:
            Unassigned
            Reporter:
            Guillaume Racicot
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: