Avoid gitignored/vim undofiles in linter

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Minor - P4
    • 8.3.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • DevProd Build
    • Fully Compatible
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      To recreate, run 

      mkdir -p './src/mongo/~/.vim/undo'
touch './src/mongo/~/.vim/undo/%home%ubuntu%mongo%src%mongo%example_file.cpp'
git status
bazel run lint

      Currently, the linter treats the binary vim undofile as a regular file, and fails to lint, even though the file is gitignored:

      Checking that all C++ files have BUILD.bazel targets...
Found C++ files without BUILD.bazel definitions:
        src/mongo/~/.vim/undo/%home%ubuntu%mongo%src%mongo%example_file.cpp

Please add these to a cpp_library target in a BUILD.bazel file in their directory
Run the following to attempt to fix the issue automatically:
        bazel run lint --fix
ERROR: Linter run failed, see details above
INFO: Run the following to try to auto-fix the errors:

      This negatively affects my workflow since I need to backup/delete my undo history in order to lint.

      The linter should avoid parsing gitignored files, but that might be performance-heavy, in which case adding a rule to avoid files in a `'.vim'` directory would also solve this issue.

      # Cleanup
rm -rf './src/mongo/~/.vim/undo'

       

            Assignee:
            Andrew Bradshaw
            Reporter:
            Joseph Obaraye
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved: