Align the functionality of useIncreasedSpilling with the previous functionality

XMLWordPrintableJSON

    • Type: Bug
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.3.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution
    • Fully Compatible
    • ALL
    • 200
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      It was

      const bool forceIncreasedSpilling = _state.allowDiskUse &&
              (kDebugBuild || internalQuerySlotBasedExecutionHashAggForceIncreasedSpilling.load());
      

      and it was changed to

      bool useIncreasedSpilling(bool allowDiskUse,
                                    SbeHashAggIncreasedSpillingModeEnum forceIncreasedSpillingMode) {
              switch (forceIncreasedSpillingMode) {
                  case SbeHashAggIncreasedSpillingModeEnum::kAlways:
                      return true;
                  case SbeHashAggIncreasedSpillingModeEnum::kNever:
                      return false;
                  case SbeHashAggIncreasedSpillingModeEnum::kInDebug:
                      return kDebugBuild && allowDiskUse;
                  default:
                      tasserted(9915702, "Unknown forceIncreasedSpillingMode");
              }
          }
      

      `useIncreasedSpilling` whould first check `allowDiskUse` and onoy if it set to true it should check the `forceIncreasedSpillingMode`

            Assignee:
            Foteini Alvanaki
            Reporter:
            Foteini Alvanaki
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: