Make ExpressionContext::variables private and provide getters

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Won't Fix
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • None
    • Query Execution
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      The PR replaces public ExpressionContext members `variables` and `variablesParseState` with private members and `variables()` and `variablesParseState()` getters, including non-const reference getter. This is the only change in this PR and it was done almost automatically with find-replace.

      This change is needed to faciliate the extraction of `variables` and related members to a separate class and have a `shared_ptr` to this class in ExpressionContext. This is not just refactoring - this is needed to fix the bug SERVER-114384

            Assignee:
            Ivan Fefer
            Reporter:
            Ivan Fefer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: