In SERVER-110060 we added code to help us catch cases where we were trying to reserve an OpTime for a new oplog entry when we shouldn't be, i.e. if we're holding the wrong intent.

However, the added code is too aggressive because it will always fire, whether we have the wrong intent (such as Intent::LocalWrite) or a correct intent (Intent::Write or Intent::BlockingWrite).

This means that the added code won't help us catch real cases where we're holding the wrong intent and trying to reserve an OpTime. It also means that the code can fire pretty much any time there's a step down and a write operation (or any operation that writes an oplog entry) occurring simultaneously.

See comments for more info.