-
Type:
Improvement
-
Resolution: Unresolved
-
Priority:
Major - P3
-
None
-
Affects Version/s: None
-
Component/s: None
-
Query Integration
-
None
-
None
-
None
-
None
-
None
-
None
-
None
except from the review of SERVER-115196:
Comment on line R54:
LogicalAggStageAPI(::MongoExtensionLogicalAggStage* ptr)
cswanson310 commented:
Did you consider or take a stab at deleting this type of constructor? [without a required ObservabilityContext] Unit tests complain? Could we perhaps file a ticket to do that?
I guess I'm open to an argument that these should always exist, but it feels safer to have the only API make developers think about whether/how they want to track metrics through this API call?
finleylau replied
Unit tests would definitely complain. I was thinking about the metrics being optional, as the SDK currently does not have any metrics. I don't feel strongly either way and would be down to filing a followup ticket to remove these constructors + update unit tests
- related to
-
SERVER-115695 Add metric tracking time spent in extension's getNext() execution
-
- Closed
-