A bazel feature was added at some point to set -Wno-inconsistent-missing-override and sometime later that config got set to only apply on Linux builds. I believe setting this flag to begin with was a mistake. The comment suggests that it was set because the inconsistent missing override warning was judged to be "noisy" and producing a large number of warnings. This flag provides valuable signal about our use of virtual and override which are commonly misused. We should have acted on the warnings when we found out about our non-compliance.

Please delete this config and ensure that we have the compile flag turned on. We may see a large number of warnings. I think we should release these to Server teams with a notice beforehand to ensure that violations get fixed, rather than file tickets on server teams to fix the warnings first and then turn on the flag. The fixes should be fairly trivial and I worry about server teams deprioritizing the work to return to compliance.

Please also consult with SP about auditing our warning-related build flags. It is highly concerning to me that this flag was configured as it is now to begin with and that we only found out about it very circumstantially through a Mac-only build failure.