Support mozJS build compatibility for 8.0

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Fixed
    • Priority: Major - P3
    • 8.3.0-rc0
    • Affects Version/s: None
    • Component/s: None
    • Query Integration
    • Fully Compatible
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      We noticed that two fixes are required so the mozJS backport builds cleanly on 8.0:

      1. fmt compatibility issue

      Problem: the fmt version shipped in the 8.0 tree does not provide fmt::format_string; it exposes fmt::string_view instead.

      Proposed fix: add a small compatibility macro used by LoggingInterface.h to map a single name to the appropriate fmt type for the configured fmt version (use fmt::format_string when available; fall back to fmt::string_view for 8.0). 

      2. Explicitly include Utility.h

      Problem: commit [5cfbc09|https://github.com/10gen/mongo/commit/5abd171fa9d539578d5f1d3d4417a4ca4606c078] changed include ordering on some files in master; 8.0 does not reflect that ordering, which causes compilation issues where StringBuffer.h relies implicitly on includes moved elsewhere.

      Proposed fix: explicitly include Utility.h in StringBuffer.h in the 8.0 tree so the header is self-contained (matches master behavior and prevents build fragility).

            Assignee:
            Aditya Deshpande
            Reporter:
            Aditya Deshpande
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: