Coverity: add GUARDED_BY to InitialSyncer and BaseCloner state

XMLWordPrintableJSON

    • Type: Task
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Replication
    • None
    • None
    • None
    • None
    • None
    • None
    • None

      What

      Add `GUARDED_BY(_mutex)` to the unprotected member fields in `InitialSyncer` and `BaseCloner`. Add `REQUIRES(_mutex)` to private helpers that read or write them.

      Files: `initial_syncer.cpp` (line 1108), `base_cloner.h` (line 178).

      Resolves: SERVER-111256, SERVER-109743

      Why

      Cloner races occur between the cloner thread and the reporting thread. Because Coverity cannot be run locally, `GUARDED_BY` annotations are the most reliable way to confirm the fix holds and to prevent these fields from being accessed without the lock in the future.

            Assignee:
            Unassigned
            Reporter:
            Denis Trailin
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: