Make nsToDatabase() return StringData instead of std::string

XMLWordPrintableJSON

    • Type: Improvement
    • Resolution: Unresolved
    • Priority: Major - P3
    • None
    • Affects Version/s: None
    • Component/s: None
    • Catalog and Routing
    • 1
    • 🟦 Shard Catalog
    • None
    • None
    • None
    • None
    • None
    • None

      The nsToDatabase() function currently returns std::string by copying from nsToDatabaseSubstring() which already returns StringData.

      Change the return type to StringData to avoid unnecessary string copies. There is a TODO comment requesting this change. All callers will need to be updated accordingly.

            Assignee:
            Unassigned
            Reporter:
            Tommaso Tocci
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: