-
Type:
Task
-
Resolution: Duplicate
-
Priority:
Major - P3
-
None
-
Affects Version/s: None
-
Component/s: None
-
None
-
RSSD
-
None
-
None
-
None
-
None
-
None
-
None
-
None
Function OplogApplicationChecks::checkOperationAuthorization(...) in src/mongo/db/commands/oplog_application_checks.cpp contained an older TODO comment without a linked SERVER ticket.
This has been disallowed recently, so whenever a PR changes a file, such TODO comments need to be either resolved or mapped to an existing SERVER ticket. I'm opening this ticket to preserve the old TODO comment.
The TODO comment in question is this one, and it suggests reusing the command parse result from inside OplogApplicationChecks::checkOperationAuthorization(...) for later, when the command is actually run. This is a potential performance optimization to avoid redundant parsing of the same command.
I cannot assess the feasibility of making this change, so this should be investigated by the team owning the code.
- duplicates
-
SERVER-123371 Reuse command parse result in applyOps oplog application checks
-
- Backlog
-
- is caused by
-
SERVER-123564 Add more tests for truncateRange oplog command inside applyOps
-
- In Code Review
-